-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect, snapshot and gracefully restore global objects in e2e test #2091
Collect, snapshot and gracefully restore global objects in e2e test #2091
Conversation
@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
187101c
to
4dc34ec
Compare
962999d
to
11397a7
Compare
11397a7
to
2d8f761
Compare
/hold |
2d8f761
to
e08ff67
Compare
eba1799
to
24934e6
Compare
/hold cancel |
91f72e2
to
eb98043
Compare
eb98043
to
38923da
Compare
38923da
to
00a1223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign rzetelskik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#2061 (comment) |
Description of your changes:
This PR extends our e2e framework to be able to snapshot, collect and restore global resources like NodeConfigs or ScyllaOperator configs. This is very important to be able to debug the disruptive serial suites that use the same object in multiple tests and the final dump just shows the last test.
This also no longer requires the NodeConfig or Resource quotas to be missing before running the e2e suite an depending on the cleanup policy and whether the object has existed before, it will be restored after the test. This also help not to mess up local setups too much but more importantly it allows you to specify a cleanup policy to avoid deleting e.g. the NodeConfig used during the test.
Also this hooks extra dumps for the artifacts dir, e.g.
e2e/cluster-0/cluster-scoped-per-ns/e2e-test-nodesetup-q6bhx-0-d7s4w/cluster-scoped/nodeconfigs.scylla.scylladb.com/cluster.yaml
Which issue is resolved by this Pull Request:
Resolves #2045
Requires